-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features: builder mode (like the builder mode of Prometheus). #324
Conversation
Hello, thank you for the contribution. That's a lot of code so will take some time to review in few rounds. |
For the change points you mentioned, do you directly modify them or do I resubmit them after modification? |
Yes, I'd expect you implement requested changes first (standard github review process 🤔). I'm willing to do final touches and nitpicking on this PR. |
Sorry for late response, I have some work to do now. I'll take over from now, thanks for contribution! |
the builder mode supports rendering load configuration pages through the response of the server. Signed-off-by: MicroOps-cn <sunlinyao@vip.qq.com>
…ustom width to payload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to also modify Openapi
# Conflicts: # src/Component/ConfigEditor.tsx # src/types.d.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MicroOps-cn can you look into a failing tests? I tried changing mocked response but getting things like undefined_0
in labels/values.
Signed-off-by: MicroOps-cn <sunlinyao@vip.qq.com>
I'm a little busy this weekend. I will update the openapi.yaml file next week. |
0aa4271
to
1c1b2ea
Compare
Signed-off-by: MicroOps-cn <sunlinyao@vip.qq.com>
Thank you for the contribution! I'll test it in my project and then do a release. |
The builder mode supports rendering load configuration pages through the response of the server.
#321
example: