Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features: builder mode (like the builder mode of Prometheus). #324

Merged
merged 16 commits into from
Dec 8, 2022

Conversation

MicroOps-cn
Copy link
Contributor

@MicroOps-cn MicroOps-cn commented Aug 29, 2022

The builder mode supports rendering load configuration pages through the response of the server.
#321
example:
builder

@MicroOps-cn MicroOps-cn changed the title New features: builder mode (like the builder mode of Prometheus). #321 #321 New features: builder mode (like the builder mode of Prometheus). Aug 29, 2022
@MicroOps-cn MicroOps-cn changed the title #321 New features: builder mode (like the builder mode of Prometheus). New features: builder mode (like the builder mode of Prometheus). Aug 29, 2022
@simPod
Copy link
Owner

simPod commented Aug 30, 2022

Hello, thank you for the contribution.

That's a lot of code so will take some time to review in few rounds.

src/Component/QueryEditor.tsx Outdated Show resolved Hide resolved
src/DataSource.ts Outdated Show resolved Hide resolved
src/Component/QueryBuilder.tsx Outdated Show resolved Hide resolved
src/Component/QueryBuilder.tsx Outdated Show resolved Hide resolved
@MicroOps-cn
Copy link
Contributor Author

For the change points you mentioned, do you directly modify them or do I resubmit them after modification?

@simPod
Copy link
Owner

simPod commented Aug 30, 2022

Yes, I'd expect you implement requested changes first (standard github review process 🤔).

I'm willing to do final touches and nitpicking on this PR.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
demo/builder/main.go Outdated Show resolved Hide resolved
spec/DataSource.jest.ts Outdated Show resolved Hide resolved
@simPod
Copy link
Owner

simPod commented Sep 16, 2022

Sorry for late response, I have some work to do now. I'll take over from now, thanks for contribution!

@simPod simPod self-assigned this Sep 20, 2022
@simPod simPod mentioned this pull request Oct 11, 2022
Copy link
Owner

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to also modify Openapi

Copy link
Owner

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MicroOps-cn can you look into a failing tests? I tried changing mocked response but getting things like undefined_0 in labels/values.

src/Component/QueryBuilderTag.tsx Show resolved Hide resolved
Signed-off-by: MicroOps-cn <sunlinyao@vip.qq.com>
@MicroOps-cn
Copy link
Contributor Author

We will need to also modify Openapi

I'm a little busy this weekend. I will update the openapi.yaml file next week.

@simPod simPod force-pushed the 0.5.x branch 2 times, most recently from 0aa4271 to 1c1b2ea Compare October 28, 2022 16:02
Signed-off-by: MicroOps-cn <sunlinyao@vip.qq.com>
@simPod simPod merged commit 704479c into simPod:0.5.x Dec 8, 2022
@simPod
Copy link
Owner

simPod commented Dec 8, 2022

Thank you for the contribution!

I'll test it in my project and then do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants