Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: propagate result code on Producer::flushMessages err #183

Merged
merged 1 commit into from
Sep 17, 2024

feat: propagate result code on `Producer::flushMessages` err

76f45f6
Select commit
Loading
Failed to load commit list.
Merged

feat: propagate result code on Producer::flushMessages err #183

feat: propagate result code on `Producer::flushMessages` err
76f45f6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 17, 2024 in 0s

80.74% (+0.10%) compared to 03b58f1

View this Pull Request on Codecov

80.74% (+0.10%) compared to 03b58f1

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.74%. Comparing base (03b58f1) to head (76f45f6).

Files with missing lines Patch % Lines
src/Clients/Producer/KafkaProducer.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   80.64%   80.74%   +0.10%     
==========================================
  Files           8        8              
  Lines         186      187       +1     
==========================================
+ Hits          150      151       +1     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.