Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a range! macro to start/end ranges using a guard object. #19

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Add a range! macro to start/end ranges using a guard object. #19

merged 2 commits into from
Jan 18, 2024

Conversation

adeschamps
Copy link
Contributor

As mentioned in #18, this implements a range! macro which is a shortcut for calling range_start! and uses a drop guard to call range_end!.

simbleau
simbleau approved these changes Jan 18, 2024
View reviewed changes
Copy link
Owner

@simbleau simbleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR.

simbleau
simbleau requested changes Jan 18, 2024
View reviewed changes
Copy link
Owner

@simbleau simbleau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the CHANGELOG and version of nvtx to 1.3?

@simbleau simbleau merged commit cddfe2a into simbleau:main Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simbleau simbleau simbleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adeschamps @simbleau