Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text scale bug #12

Closed
wants to merge 1 commit into from
Closed

Fix text scale bug #12

wants to merge 1 commit into from

Conversation

siqwin
Copy link

@siqwin siqwin commented Apr 4, 2019

Fix #10

@simc
Copy link
Owner

simc commented Apr 5, 2019

Thanks for the pull request but I found a fix which still allows custom scale.

@simc simc closed this Apr 5, 2019
@siqwin
Copy link
Author

siqwin commented Apr 5, 2019

I tried your last version and it not working for me: if custom scale is set (big size), and there is not enough space for text, then it simply does not fit (clip). Please check it. By the way, I did not remove the custom scaling option in the pull request.

@simc
Copy link
Owner

simc commented Apr 5, 2019

Could you please provide a small sample which shows the issue?

@siqwin
Copy link
Author

siqwin commented Apr 8, 2019

Sorry, I tried it on an empty project and the latest version works fine. Thank you!

@simc
Copy link
Owner

simc commented Apr 8, 2019

Perfect :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants