-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Topological sort of dependencies #114
Conversation
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
============================================
+ Coverage 80.00% 100.00% +20.00%
============================================
Files 2 2
Lines 35 256 +221
Branches 7 64 +57
============================================
+ Hits 28 256 +228
+ Misses 7 0 -7
Continue to review full report at Codecov.
|
@cobraz I need this to get released for some other experiments now :) |
Hmm. Found a couple of bugs to squash first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this awesome feature!
Hmm. Found a couple of bugs to squash first.
I can't find any obvious bugs with this. Let me know if you want help with that!
In both of the visitor functions in util, we throw. This crashes when dealing with unknown named types. Should probably just break and continue. But needs a test that triggers it before fixing |
Sort roots topologically by their dependencies before generating code. Makes sure non-lazy types are written in the correct order.
I'll add a couple of more tests, but apart from that, this should be ready. This should land before releasing 3.0