Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set strict mode #22

Closed
simevo opened this issue Jul 24, 2018 · 2 comments
Closed

set strict mode #22

simevo opened this issue Jul 24, 2018 · 2 comments
Labels
assessment

Comments

@simevo
Copy link
Owner

simevo commented Jul 24, 2018

from the onelogin/php-saml documentation:

In production, the strict parameter MUST be set as "true"

and:

If 'strict' is True, then the PHP Toolkit will reject unsigned or unencrypted messages if it expects them to be signed or encrypted. Also it will reject the messages if the SAML standard is not strictly followed: Destination, NameId, Conditions ... are validated too.
@simevo
Copy link
Owner Author

simevo commented Aug 3, 2018

should be fixed by d00cbc5#diff-6d10993b10a46b9c0bdf023f421e6d1aR35

lorenzocattaneo pushed a commit that referenced this issue Aug 11, 2018
Merge pull request #26 from simevo/feature/class-wrapper
6038d96 
Feature/class wrapper; fixes #2, #12, #13, #22
@simevo
Copy link
Owner Author

simevo commented Aug 13, 2018

https://github.com/simevo/spid-php2/blob/master/src/Config/OneLoginConfig.php#L46

@simevo simevo closed this as completed Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assessment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simevo