Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace arch with uname -m #9

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: replace arch with uname -m #9

merged 1 commit into from
Oct 21, 2024

Conversation

bas-ie
Copy link
Contributor

@bas-ie bas-ie commented Oct 7, 2024

This:

  • replaces arch with uname -m

Why? arch is no longer included in coreutils by default. This will probably cause some confusion for users of up-to-date distributions, who will see something like

arch: command not found

when trying to use this plugin. uname -m does the same thing, so may as well use that 🙂

Thanks for the plugin!

@bas-ie bas-ie changed the title Replace arch with uname -m fix: replace arch with uname -m Oct 7, 2024
@wbh1
Copy link

wbh1 commented Oct 7, 2024

This has the additional benefit of fixing broken installations on Intel Macs.

Before I would get 404's:

asdf-ruff: Could not download https://github.com/astral-sh/ruff/releases//download/0.6.9/ruff-i386-apple-darwin.tar.gz

With @richchurcher 's branch, I can successfully install ruff.

@simhem simhem merged commit fabca11 into simhem:main Oct 21, 2024
4 checks passed
@bas-ie bas-ie deleted the use-uname branch October 21, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants