Collect pod logs #212
Open
Collect pod logs #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaplanelad
added
enhancement
ortz
suggested changes
Apr 20, 2020
There was a problem hiding this comment.
hi @kaplanelad , some comments.. other than that, looks good.
|
@liorbd can you please resolve the |
liorbd
force-pushed
the
feature/195-collect-pods-logs-v3
branch
from
3a5e360 to
6307e44
Compare
|
@kaplanelad done |
ortz
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Backend Feature
UI Feature
What this PR does / why we need it:
Collect pod container logs
Which issue(s) this PR fixes (if exists):
Fixes #195