Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge reasonable pull requests as much as possible #3

Closed
5 tasks done
simnalamburt opened this issue Dec 31, 2014 · 6 comments · Fixed by #107
Closed
5 tasks done

Merge reasonable pull requests as much as possible #3

simnalamburt opened this issue Dec 31, 2014 · 6 comments · Fixed by #107

Comments

@simnalamburt
Copy link
Owner

@simnalamburt simnalamburt mentioned this issue Mar 5, 2015
Open
@dsummersl
Copy link
Collaborator

Sounds good @simnalamburt I'll get my project up to date with yours and submit a PR soonish.

@simnalamburt
Copy link
Owner Author

Thank you very much!

@dsummersl
Copy link
Collaborator

I like slj#27 (plus they include doc updates in the PR, which is nice :)). Sound good?

@simnalamburt
Copy link
Owner Author

Sounds not bad. Looks like we need some rebase process.

@dsummersl
Copy link
Collaborator

For...j3master to rebase against our fork? (sorry little confused about what you meant).

In the meantime I've added j3master's fork as a remote and merged it into a new branch to make this PR:

#7

Could you take a peak when you get a chance - I played with a couple combinations of settings and it appears to work as advertized. I do like it even.

@simnalamburt
Copy link
Owner Author

Sorry for confusion, you did what I wanted

ypid pushed a commit to ypid/vim-mundo that referenced this issue Dec 28, 2020
@olivierverdier @ypid
Display time stamps in ISO time format (fix regression)
e469bed 
Fixes: simnalamburt#3
Closes: sjl/gundo.vim#28

Regression: 3b94d2d
Introduced in: 32142a6
@ypid ypid mentioned this issue Dec 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display time stamps in ISO time format (fix regression) ypid/vim-mundo
2 participants
@dsummersl @simnalamburt