Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: minimise the copy/think/paste needed to get the minimal impleme… #2951

Merged
merged 2 commits into from
Apr 14, 2024
Merged

docs: minimise the copy/think/paste needed to get the minimal impleme… #2951

merged 2 commits into from
Apr 14, 2024

Conversation

ewann
Copy link
Contributor

@ewann ewann commented Apr 12, 2024

…ntation working

nice project :)

stepping through this for the first time, I decided to offer this back for consideration.

simolus3
simolus3 reviewed Apr 14, 2024
View reviewed changes
Copy link
Owner

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree that seeing the full snippet again can make it easier for users to just copy something that works.

docs/pages/docs/setup.md Outdated Show resolved Hide resolved
simolus3
simolus3 approved these changes Apr 14, 2024
View reviewed changes
Copy link
Owner

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simolus3 simolus3 merged commit ca0dee4 into simolus3:develop Apr 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simolus3 simolus3 simolus3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewann @simolus3