Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.js #45

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Update index.js #45

merged 1 commit into from
Jan 3, 2018

Conversation

icai
Copy link
Contributor

@icai icai commented Oct 12, 2017 •
edited
Loading

bugfix

#44

vastolf
vastolf approved these changes Oct 18, 2017
View reviewed changes
Copy link

@vastolf vastolf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this/can confirm that it is working. I was having the same problem when using variables in templates but this pull request definitely fixes the problem.

@vastolf vastolf mentioned this pull request Oct 18, 2017
Closed
@bezoerb bezoerb assigned bezoerb and unassigned bezoerb Jan 3, 2018
@bezoerb bezoerb merged commit 77e3ff0 into simon-dt:master Jan 3, 2018
@bezoerb
Copy link
Collaborator

bezoerb commented Jan 3, 2018

Looks good. Thanks @icai & @astolfivincent

@vastolf
Copy link

vastolf commented Jan 15, 2018

@bezoerb thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vastolf vastolf vastolf approved these changes

@bezoerb bezoerb bezoerb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icai @bezoerb @vastolf