Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Window stats manager #2

Merged
merged 5 commits into from
Sep 25, 2018
Merged

Add Window stats manager #2

merged 5 commits into from
Sep 25, 2018

Conversation

deathart
Copy link
Contributor

No description provided.

@simon-fraser simon-fraser self-assigned this Sep 19, 2018
@simon-fraser
Copy link
Owner

simon-fraser commented Sep 19, 2018 •
edited
Loading

@deathart Can you ensure the package is added to the package.json file and that there are no errors when running npm run lint

@deathart
Copy link
Contributor Author

Oups, I add package

@deathart
Copy link
Contributor Author

And run lint :)

@simon-fraser
Copy link
Owner

@deathart the application appears to fail build now npm start do you want to check why this is happening with the addition of the electron-window-stats module.

@deathart
Copy link
Contributor Author

Resolved :)

@simon-fraser simon-fraser merged commit 5547a66 into simon-fraser:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simon-fraser simon-fraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deathart @simon-fraser