-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve DU download #24
Conversation
Thanks for the PR, but I'm not too keen to go ahead with the current implementation because it feels very tied to your specific environment, so ideally I would like to come up with something more generic. First of all let me ask this question: in the issue you commented that you needed to be able to use a local file system path, so I would like to understand if the requirement changed now. |
Can you explain what do you mean by tied to For what I understand, anyone using system wide proxy server, it is recommended or optimal way to set environmental variables. AFAIK
Requirements still exists. |
I'm not sure why you closed this, I think the request makes sense, I just wanted to come up with a more generic way to handle this |
Please share idea, I will open new pull request. |
If your requirement is to be able to load the file from the file system, can't we just handle it in the existing environment variable and, if it's a url, download it, otherwise copy the file from the file system to the expected location (or even just use it as-is)? |
These are two different requirements:
Sorry for the confusion |
Okay fair enough. I'm happy to get a PR which does either or both. When possible, please consider including unit tests to check that this works |
This pull request adds
exe
already downloaded then skip download