fix(table): rows are now correctly string[][]

simonecorsi · Oct 8, 2021 · 73de9ad · 73de9ad
1 parent f85c3ac
commit 73de9ad
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/index.ts b/src/index.ts
@@ -65,8 +65,8 @@ export class Markdown {
     return this;
   }
 
-  table(columns = [], rows = [], fmtFnc?): this {
-    this.addLine(table(columns, rows, fmtFnc));
+  table(columns = [], rows = []): this {
+    this.addLine(table(columns, rows));
     return this;
   }
 

diff --git a/src/utils/common.ts b/src/utils/common.ts
@@ -1,14 +1,14 @@
 export const CR = '\n\n';
 export const LB = '\n';
 
-export const table = (
-  headers: string[] = [],
-  rows: string[] = [],
-  fmtFnc = (rowValue: any) => rowValue
-) => {
+export const table = (headers: string[] = [], rows: string[][] = []) => {
   let t = '';
   t += `| ${headers.join(' | ')} |${LB}|${' --- |'.repeat(headers.length)}`;
-  t += `${LB}| ${rows.map(fmtFnc).join(' | ')} |`;
+
+  for (const row of rows) {
+    t += `${LB}| ${row.join(' | ')} |`;
+  }
+
   return t;
 };
 

diff --git a/test/common.ts b/test/common.ts
@@ -50,7 +50,7 @@ tap.test('code', (t) => {
 
 tap.test('table', (t) => {
   const headers = ['id', 'name'];
-  const rows = ['1', 'Ajeje'];
+  const rows = [['1', 'Ajeje']];
   let out = '| id | name |\n';
   out += '| --- | --- |\n';
   out += '| 1 | Ajeje |';

diff --git a/test/index.ts b/test/index.ts
@@ -30,7 +30,7 @@ tap.test('Shoud generate Markdown', async (t) => {
       )}`
     )
     .header('Table', 2)
-    .table(['id', 'name'], ['1', 'Simone'])
+    .table(['id', 'name'], [['1', 'Simone']])
     .header('List', 2)
     .list([
       { text: 'list1', depth: 0 },

diff --git a/types/index.d.ts b/types/index.d.ts
@@ -17,7 +17,7 @@ export declare class Markdown {
     paragraph(data: string | number): this;
     header(title: string, n?: number): this;
     image(filepath: string, altText?: string): this;
-    table(columns?: any[], rows?: any[], fmtFnc?: any): this;
+    table(columns?: any[], rows?: any[]): this;
     list(items?: ListItems<ListItem>, numbered?: boolean): this;
     tasks(items?: ListItems<TaskItem>): this;
 }
diff --git a/types/utils/common.d.ts b/types/utils/common.d.ts
@@ -1,6 +1,6 @@
 export declare const CR = "\n\n";
 export declare const LB = "\n";
-export declare const table: (headers?: string[], rows?: string[], fmtFnc?: (rowValue: any) => any) => string;
+export declare const table: (headers?: string[], rows?: string[][]) => string;
 export declare const italic: (text?: string) => string;
 export declare const bold: (text?: string) => string;
 export declare const link: (text: any, url: any) => string;