int vector mapper #2 #236
Open
int vector mapper #2 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality to the int-vector-mapper (#232) such as [x] typedef for a
read_only_mapper[x] support class which allows the creation of output buffer:write_out_buffer[x] support class which supports the creation of temporary files which are deleted by the int-vector-mapper destructortemp_file_buffer[x] tests for the new functionality the only remaining open functionality of theint-vector-bufferwhich is not yet implemented is the ability to handleram_files. However, I suggest the following: - Remove the majority of the ram file functionality. - When construct_im is called, set a flag somewhere which then forces the int-vector-mapper to not unmap the file in the destructor. Thus, if enough memory is available it remains in memory. - When the construct_im method is done, there is some call to "clean up" which would unmap everything and delete the leftover files (or nothing will be written to disk in the first place)