make parameter k in k2 tree completely constant #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the compiler to optimize for k values which are a power of two, getting rid of expensive div and imul instructions. Many loops get unrolled as well. The private member variable k_k was preventing it as k_k is not constant, e.g., loading from istream sets it. This is also the only "lost" functionality, unserialize from a file without knowing the value k before. All other assignments, like in copy-ctor and operator=(), don't make any sense as one can only call them with the same type which implies the same k.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the compiler to optimize for k values which are a power of
two, getting rid of expensive div and imul instructions. Many loops get
unrolled as well.
The private member variable k_k was preventing it as k_k is not constant,
e.g., loading from istream sets it. This is also the only "lost"
functionality, unserialize from a file without knowing the value k
before. All other assignments, like in copy-ctor and operator=(), don't
make any sense as one can only call them with the same type which
implies the same k.