add missing ifdef (#22)

simonpintarelli · Jun 17, 2024 · e7ea662 · e7ea662
1 parent 3b64a5a
commit e7ea662
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 12 deletions.
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -16,9 +16,6 @@ target_link_libraries(test_stride_dvector PRIVATE nlcglib_core)
 add_executable(test_mpi_wrapper test_mpi_wrapper.cpp)
 target_link_libraries(test_mpi_wrapper PRIVATE nlcglib_core)
 
-add_executable(test_solver test_solver.cpp)
-target_link_libraries(test_solver PRIVATE nlcglib_core)
-
 add_executable(test_mvector_cuda test_mvector_cuda.cpp)
 target_link_libraries(test_mvector_cuda PRIVATE nlcglib_core)
 
@@ -28,9 +25,6 @@ target_link_libraries(test_deep_copy PRIVATE nlcglib_core)
 add_executable(test_smearing test_smearing.cpp)
 target_link_libraries(test_smearing PRIVATE nlcglib_core)
 
-# add_executable(test_check_alignment test_check_alignment.cpp)
-# target_link_libraries(test_check_alignment PRIVATE nlcglib_core)
-
 add_executable(test_buffer test_buffer.cpp)
 target_link_libraries(test_buffer PRIVATE nlcglib_core)
 
@@ -43,6 +37,9 @@ target_link_libraries(test_lambda_device PRIVATE nlcglib_core)
 
 add_executable(test_gpu test_gpu.cpp)
 target_link_libraries(test_gpu PRIVATE nlcglib_core)
+
+add_executable(test_solver test_solver.cpp)
+target_link_libraries(test_solver PRIVATE nlcglib_core)
 endif()
 
 add_executable(test_utils test_utils.cpp)

diff --git a/test/test_kokkos.cpp b/test/test_kokkos.cpp
@@ -98,6 +98,9 @@ kokkos_reduction_device()
 #elif defined __NLCGLIB__ROCM
   using space = Kokkos::Experimental::HIPSpace;
   using exec_space = Kokkos::Experimental::HIP;
+#else
+  using space = Kokkos::HostSpace;
+  using exec_space = Kokkos::Serial;
 #endif
 
   int n = 100;
@@ -115,11 +118,6 @@ kokkos_reduction_device()
 }
 
 
-struct fun
-{
-  __device__ __host__ double operator()(double x) const { return 1 / (1 + exp(x)); }
-};
-
 int
 main(int argc, char* argv[])
 {

diff --git a/test/test_solver.cpp b/test/test_solver.cpp
@@ -61,7 +61,6 @@ run_unmanaged()
   }
 }
 
-
 int
 main(int argc, char *argv[])
 {

diff --git a/unit_tests/local/test_solver_wrappers.cpp b/unit_tests/local/test_solver_wrappers.cpp
@@ -52,6 +52,9 @@ TestSymSolve<T>::SetUp()
   matrix_t H(Map<>(Communicator(), SlabLayoutV({{0, 0, ncols, ncols}})));
 }
 
+#if (!__NLCGLIB__CUDA) && (!__NLCGLIB__ROCM)
+// pass
+#else
 // https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#typed-tests
 #ifdef __NLCGLIB__CUDA
 using KokkosMemTypes = ::testing::Types<Kokkos::CudaSpace, Kokkos::HostSpace>;
@@ -90,3 +93,5 @@ TYPED_TEST(TestSymSolve, PotrfPotrs)
     }
   }
 }
+
+#endif