[Trimming] Feature switch: IVisual scanning support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
force-pushed
the
xaml-load-feature-flag
branch
from
06717be to
bf76c49
Compare
simonrozsival
force-pushed
the
xaml-load-feature-flag
branch
from
7a2e8f4 to
abb35ee
Compare
simonrozsival
force-pushed
the
feature-switch-ivisual-assembly-scanning
branch
from
447b0e3 to
83cf16c
Compare
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: This PR will be rebased on main and moved to the official MAUI repo once dotnet#19310 is merged
Description of Change
The current implementation of
VisualTypeConverter.InitMappingsisn't trimming-safe. It scans all types in all assemblies and looks for classes implementing theIVisualinterface.Customers should instead use the existing
[assembly: Visual(...)]attribute to register theirIVisualclasses.TODO: We need a follow-up issue to update the docs -- although I can only find Xamarin Forms docs... where are the MAUI docs?
TODO: Link to docs
Issues Fixed
Contributes to dotnet#19397, fixes dotnet#4937