Fix overload check #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ namespace BindingSourceGen.UnitTests; | |||
|
|
|||
| public class DiagnosticsTests | |||
| { | |||
| [Fact] | |||
| [Fact(Skip = "Improve detecting overloads")] | |||
There was a problem hiding this comment.
What's wrong with the test? Does it report wrong diagnostic?
There was a problem hiding this comment.
As we based our overload detection on checking the type of the arguments now it will report that we are using a wrong overload as the second argument is not lambda.
There was a problem hiding this comment.
OK. It's acceptable that it reports BSG0004 for now. Let's deal with this later and merge it as is.
simonrozsival
approved these changes
Apr 9, 2024
simonrozsival
merged commit 8eb99d9
into
simonrozsival:binding-source-generator
2 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.