[Trimming] Simpler image source service provider #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix trimming warnings in
ImageSourceServiceProvider
without changing the existing APIs. The main idea of this approach is to iterate over all the registered image source to image source service mappings (there aren't that many usually + we're caching the result of the lookup anyway) and find the best match for the input image source type.There are just a few TODOs:
IImageSourceServiceCollection
and they're not part of the publicly declared API yetThe main question I think we need to ansewer: Is this a better way to go about the
ImageSourceServiceProvider
than what Mitch has been working on with keyed services? The change is certainly a lot less invasive, and it doesn't significantly change how DI works, but maybe we need the disruptive change to be able to phase outMauiFactory
eventually?