Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml from setup.py #34

Closed
simonw opened this issue Nov 14, 2024 · 4 comments
Closed

Switch to pyproject.toml from setup.py #34

simonw opened this issue Nov 14, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Nov 14, 2024

Refs:

@simonw simonw added the enhancement New feature or request label Nov 14, 2024
@simonw
Copy link
Owner Author

simonw commented Nov 15, 2024

Error:

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      error: Multiple top-level modules discovered in a flat-layout: ['asgi_csrf', 'test_asgi_csrf'].

@simonw
Copy link
Owner Author

simonw commented Nov 15, 2024

I'm building a wheel in the tests so I can test that the wheel installs cleanly.

@simonw
Copy link
Owner Author

simonw commented Nov 15, 2024

  with:
    name: python-packages
    path: dist/
    if-no-files-found: warn
    compression-level: 6
    overwrite: false
    include-hidden-files: false
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.15/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.15/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.15/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.15/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.15/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.15/x64/lib
With the provided path, there will be 2 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Looks like the name needs to differ for each build. I'm going to upload the wheel just for the Python 3.12 one.

@simonw
Copy link
Owner Author

simonw commented Nov 15, 2024

A pip install of those generated files worked. I'm going to land this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant