Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<form class="core"> #20

Closed
simonw opened this issue Sep 4, 2024 · 1 comment
Closed

<form class="core"> #20

simonw opened this issue Sep 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Sep 4, 2024

Refs:

@simonw simonw added the enhancement New feature or request label Sep 4, 2024
@simonw
Copy link
Owner Author

simonw commented Sep 4, 2024

Tests are failing because of a change in 1.0a15 where FTS tables are no longer treated as hidden: https://docs.datasette.io/en/latest/changelog.html#a15-2024-08-15

async def iterate_searchable_tables(datasette, request):
for db_name, database in datasette.databases.items():
hidden_tables = set(await database.hidden_table_names())

For the purposes of this plugin I think tables ending in _fts should still be treated as hidden, or we will see the same results twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant