Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename datasette_metadata_column_entries internal tables to e.g. metadata_columns #2382

Closed
simonw opened this issue Aug 5, 2024 · 2 comments

Comments

@simonw
Copy link
Owner

simonw commented Aug 5, 2024

Currently the internal metadata tables are called:

  • datasette_metadata_column_entries
  • datasette_metadata_instance_entries
  • datasette_metadata_resource_entries
  • datasette_metadata_database_entries

But the catalog tables are:

  • catalog_columns
  • catalog_databases
  • catalog_foreign_keys
  • catalog_indexes
  • catalog_tables

Renaming the metadata columns like so would be more consistent:

  • metadata_instance - singular because there is only one instance
  • metadata_databases
  • metadata_resources
  • metadata_columns
@simonw
Copy link
Owner Author

simonw commented Aug 5, 2024

I'm going to add the schema to the documentation too, using Cog - it will go here: https://docs.datasette.io/en/latest/internals.html#datasette-s-internal-database

@simonw
Copy link
Owner Author

simonw commented Aug 5, 2024

I shipped this to a Datasette Cloud test instance running datasette-visible-internal-db and it worked:

CleanShot 2024-08-05 at 14 26 35@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant