Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip over "queries" blocks when processing database-level metadata items #2386

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

asg017
Copy link
Collaborator

@asg017 asg017 commented Aug 7, 2024

Before metadata that looked like:

databases:
  legislators:
    tables:
      offices:
        summary: office address or sumtin
    queries:
      millenntial_represetatives:
        summary: Social media accounts for current legislators

Would error with:

image

That's because when processing databases.legislators items, we skip over tables but not queries. We "skip" them because we processing them separately as "table-level" metadata items.

Don't merge yet, want to test this more. Shouldn't we also have a block to process queries separately too?


📚 Documentation preview 📚: https://datasette--2386.org.readthedocs.build/en/2386/

@simonw simonw marked this pull request as ready for review August 8, 2024 15:49
@simonw simonw mentioned this pull request Aug 15, 2024
3 tasks
@simonw
Copy link
Owner

simonw commented Aug 15, 2024

We need a test for this. Do we need to do anything else before we land it?

@simonw simonw merged commit 0dd41ef into simonw:main Aug 16, 2024
19 checks passed
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.54%. Comparing base (f6bd2bf) to head (fe97ef3).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2386      +/-   ##
==========================================
- Coverage   92.55%   92.54%   -0.02%     
==========================================
  Files          41       41              
  Lines        6410     6421      +11     
==========================================
+ Hits         5933     5942       +9     
- Misses        477      479       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

simonw added a commit that referenced this pull request Aug 16, 2024
simonw added a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants