Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed-multi shows no error for invalid file paths #274

Closed
m0nac0 opened this issue Sep 13, 2023 · 0 comments
Closed

embed-multi shows no error for invalid file paths #274

m0nac0 opened this issue Sep 13, 2023 · 0 comments
Labels
Milestone

Comments

@m0nac0
Copy link

m0nac0 commented Sep 13, 2023

I found out about this while I tried getting embed-multi with the --files option to work on windows. If I specify an invalid path (e.g. because I use windows-typical backslashes instead of forward slashes or because I specify a non-existing folder), I don't get an error, but a progress bar that quickly reaches 100%.

I think it might be a good idea to show an error here to prevent confusion.

@simonw simonw added this to the 0.11 milestone Sep 15, 2023
simonw added a commit that referenced this issue Sep 19, 2023
* Fix issue with reading directories in `iterate_files()` (#280)
* Add directory checking logic in `iterate_files()` (#274)
* Added tests for #282, #274, #280

---------

Co-authored-by: Simon Willison <swillison@gmail.com>
@simonw simonw closed this as completed Sep 19, 2023
simonw added a commit that referenced this issue Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants