Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI against macOS and Windows too #408

Merged
merged 6 commits into from
Jan 27, 2024
Merged

Run CI against macOS and Windows too #408

merged 6 commits into from
Jan 27, 2024

Conversation

simonw
Copy link
Owner

@simonw simonw commented Jan 27, 2024

@simonw simonw added the qa label Jan 27, 2024
@simonw
Copy link
Owner Author

simonw commented Jan 27, 2024

Got some interesting Windows test failures:

        result = runner.invoke(
            llm.cli.cli, ["chat", "-m", "mock"], input="Hi\nHi two\nquit\n"
        )
>       assert result.exit_code == 0
E       assert 1 == 0
E        +  where 1 = <Result IndexError("Not a valid key: '\\e[d'")>.exit_code

Could that be because Windows wants \r\n?

And a whole bunch relating to paths:

>           assert rows == [
                {"id": "file1.txt", "content": "hello world"},
                {"id": "file2.txt", "content": "goodbye world"},
                {"id": "nested/more/three.txt", "content": "three"},
                {"id": "nested/one.txt", "content": "one"},
                {"id": "nested/two.txt", "content": "two"},
            ]
E           AssertionError: assert [{'content': ...ed\\two.txt'}] == [{'content': ...ted/two.txt'}]
E             At index 2 diff: {'id': 'nested\\more\\three.txt', 'content': 'three'} != {'id': 'nested/more/three.txt', 'content': 'three'}
E             Full diff:
E               [
E                {'content': 'hello world', 'id': 'file1.txt'},
E                {'content': 'goodbye world', 'id': 'file2.txt'},
E             -  {'content': 'three', 'id': 'nested/more/three.txt'},
E             ?                                    ^    ^
E             +  {'content': 'three', 'id': 'nested\\more\\three.txt'},
E             ?                                    ^^    ^^
E             -  {'content': 'one', 'id': 'nested/one.txt'},
E             ?                                  ^
E             +  {'content': 'one', 'id': 'nested\\one.txt'},
E             ?                                  ^^
E             -  {'content': 'two', 'id': 'nested/two.txt'},
E             ?                                  ^
E             +  {'content': 'two', 'id': 'nested\\two.txt'},
E             ?                                  ^^
E               ]

@simonw
Copy link
Owner Author

simonw commented Jan 27, 2024

I'd like to fix those test failures, but I also want to ship a 0.13.1 release quickly. So I'm going to mark a bunch of tests as expected to fail on Windows.

@simonw
Copy link
Owner Author

simonw commented Jan 27, 2024

Cog check failed:

Line |
   3 |    -p "import sys, os; sys._called_from_test=True; os.environ['LLM_USE …
     |    ~~
     | The term '-p' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the
     | spelling of the name, or if a path was included, verify that the path is correct and try again.

Error: Process completed with exit code 1.

@simonw simonw merged commit 8021e12 into main Jan 27, 2024
61 checks passed
@simonw simonw deleted the windows-ci branch January 27, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant