Add option to bypass Content-Security-Policy when executing Javascript #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #114
Adds a
--bypass-csp
option to the commands that allow Javascript to be executed.The additional test case that has been added loads Github and attempts to load an external module. With the
--bypass-csp
flag this will work. You can execute the following on the current version ofshot-scraper
to see it failing:The above will continue to fail with this change until
--bypass-csp
is added.I have added the flag to the documentation by have not added a new documentation block to the Javascript page for this yet. I'm happy to write up an example if you're keen to accept this PR.
I'm also interested in feedback in how the help text should be phrased. I went with the simplest possible phrasing but it does assume that the user knows what a CSP is.
📚 Documentation preview 📚: https://shot-scraper--116.org.readthedocs.build/en/116/