Add browser arguments option #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref simonw#137 This change adds `--browser-args` option to the CLI, then passes a list of arguments to the browser launch function. The argument can be included multiple times to list multiple arguments. This enables users to pass flags to the browser, such as `--font-render-hinting=none`, `--disable-gpu`, etc. These flags can have an effect on how screenshots are captured across different platforms. Detailed reason here: simonw#137
|
This is a neat change. I'm going to merge as-is, but I'm not a fan of capitalized short options so I'll remove the I'll also rename |
simonw
added a commit
that referenced
this pull request
Feb 5, 2024
simonw
added a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #137
This change adds
--browser-argsoption to the CLI, then passes a list of arguments to the browser launch function.The argument can be included multiple times to list multiple arguments.
This enables users to pass flags to the browser, such as
--font-render-hinting=none,--disable-gpu, etc.These flags can have an effect on how screenshots are captured across different platforms.
Detailed reason here: #137
📚 Documentation preview 📚: https://shot-scraper--138.org.readthedocs.build/en/138/