Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --wait-for and --timeout to pdf command #161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miccou
Copy link

@miccou miccou commented Nov 19, 2024

This PR adds the arguments --wait-for and --timeout to the shot-scraper pdf command to enable more nuanced waiting when generating PDFs.

I just copied the implementation from the shot method.


📚 Documentation preview 📚: https://shot-scraper--161.org.readthedocs.build/en/161/

@miccou
Copy link
Author

miccou commented Dec 2, 2024

Hello @simonw, did you get a chance to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant