Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff as a linter #33

Closed
simonw opened this issue Jun 29, 2023 · 1 comment
Closed

Use ruff as a linter #33

simonw opened this issue Jun 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Jun 29, 2023

Partly to get experience using ruff.

@simonw simonw added the enhancement New feature or request label Jun 29, 2023
@simonw
Copy link
Owner Author

simonw commented Jun 29, 2023

% ruff check .
symbex/cli.py:235:43: F841 [*] Local variable `ex` is assigned to but never used
symbex/cli.py:341:13: F811 Redefinition of unused `filter` from line 322
symbex/lib.py:78:89: E501 Line too long (93 > 88 characters)
tests/example_symbols.py:1:20: F401 [*] `typing.Union` imported but unused
tests/example_symbols.py:98:8: F722 Syntax error in forward annotation: `I can put anything here`
tests/example_symbols.py:99:9: F722 Syntax error in forward annotation: ``
tests/example_symbols.py:100:9: F722 Syntax error in forward annotation: `
;+*&^564835(---^&*34`
tests/example_symbols.py:108:25: F821 Undefined name `Iterable`
tests/example_symbols.py:109:6: F821 Undefined name `List`
tests/example_symbols.py:109:17: F821 Undefined name `AST`
tests/example_symbols.py:109:22: F821 Undefined name `Optional`
tests/test_symbex.py:63:89: E501 Line too long (125 > 88 characters)
tests/test_symbex.py:71:89: E501 Line too long (99 > 88 characters)
tests/test_symbex.py:80:89: E501 Line too long (99 > 88 characters)
tests/test_symbex.py:85:89: E501 Line too long (99 > 88 characters)
tests/test_symbex.py:203:89: E501 Line too long (92 > 88 characters)
tests/test_symbex.py:204:89: E501 Line too long (114 > 88 characters)
tests/test_symbols.py:38:89: E501 Line too long (98 > 88 characters)
tests/test_symbols.py:42:89: E501 Line too long (106 > 88 characters)
Found 19 errors.
[*] 2 potentially fixable with the --fix option.

I'm not going to fix the problems it tests/example_symbols.py because that's test data that is meant to have some weird problems in it.

I'm also not going to bother fixing the line-too-long things in tests/.

@simonw simonw closed this as completed in da680e3 Jun 29, 2023
simonw added a commit that referenced this issue Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant