Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols mode should include trailing colons #39

Closed
simonw opened this issue Sep 2, 2023 · 2 comments
Closed

Symbols mode should include trailing colons #39

simonw opened this issue Sep 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Sep 2, 2023

Noticed this:

symbex '*alias*' -f ../llm/llm/__init__.py -sn
def get_models_with_aliases() -> List[?]

def get_embedding_models_with_aliases() -> List[?]

def get_embedding_model_aliases() -> Dict[(str, EmbeddingModel)]

def get_model_aliases() -> Dict[(str, Model)]

def set_alias(alias, model_id_or_alias)

def remove_alias(alias)

Those signatures would be valid Python if they had a : at the end.

Even more so with docstrings:

symbex '*alias*' -f ../llm/llm/__init__.py -ns --docs --documented
def set_alias(alias, model_id_or_alias)
    "Set an alias to point to the specified model."

def remove_alias(alias)
    "Remove an alias."
@simonw simonw added the bug Something isn't working label Sep 2, 2023
@simonw
Copy link
Owner Author

simonw commented Sep 2, 2023

After the fix:

def set_alias(alias, model_id_or_alias):
    "Set an alias to point to the specified model."

def remove_alias(alias):
    "Remove an alias."

@simonw simonw closed this as completed in cd7eae3 Sep 2, 2023
simonw added a commit that referenced this issue Sep 2, 2023
@simonw
Copy link
Owner Author

simonw commented Sep 2, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant