Add type="button" to prevent submits when used inside a form
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Wow, never thought a |
|
Please note that the package was moved from |
|
@simonwep, can you please release this and other merged commits after 0.4.3 as a new version? I am currently pointing to the GitHub link instead of a version in package.json and it will make things simpler especially inside corporate networks that usually restrict outbound network calls. |
|
@astronomersiva Exactly what I wanted :) Give me 5min. |
|
Thanks a ton @simonwep 👍 I can see 0.4.4 in the registry now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this amazing library!
I upgraded from 0.3.2 and noticed that when pickr is used inside forms, the form is submitted on opening the color picker. This is because, the buttons do not have a
type="button"attribute and hence defaults to a value ofsubmitwhich ends up submitting the form.I have added
type="button"in all buttons in the code.