Add HasOne Association #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Implement simple has_many association which can help to cache result and add some test cases. As pdc gem only reads data from pdc server, this patch only implement get related association behavior, not including post action. 2. Change some rubocop configurations Known issues: 1. Need more test cases. 2. Haven't change existing api which can use has_many association like Release, will change it in future patches. JIRA: PDC-1685
According to some PDC server's primary_key is multiple, add a mapping in identity. Not sure if this a good implementation or not. JIRA: PDC-1685
simozhan
force-pushed
the
add_association_has_one
branch
from
aaf0847 to
d67c65f
Compare
simozhan
force-pushed
the
add_association_has_many
branch
from
f06cb84 to
56de980
Compare
simozhan
force-pushed
the
add_association_has_many
branch
from
7d2b5b1 to
a42c614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to some PDC server's primary_key is multiple,
add a mapping in identity. Not sure if this a good implementation
or not.
JIRA: PDC-1685