-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Labels for channels names supported #74
Comments
In general we should have a place where the channel_name _convention is configured. A good test would be to process the data with channels named john, paul, george and ringo |
After stewing on this for a while, although I really like the idea of generic channel names, it is not clear that is appropriate for standard MT processing. The TFs are generally relationships between two electric fields that span the plane of the local earth, and three magnetic fields. The nomenclature of "ex", "ey", "hx", "hy", "hz" supports this in general. Generic channel names could be supported up to TF estimation step, and then could be mapped onto these common labels during TF estimation. That would be fine for the SS and RR cases. For multiple station, we would need to address some variant of this issue, even if it were to replace the channel name with the concatenation of survey-station-component |
This issue has reared it's head now that we are working on LEMI data, because LEMI standard names its channels: 'bx', 'by', 'bz', 'e1', 'e2', 'e3', 'e4'. |
Presumably, we could process If we tried to accomodate TFs that were w.r.t. magnetics and an arbitrary collection of dipoles, this would be really great because we could use this for NFIP surveys, but this is an MT project, and probably should stay with the current scheme. So, that means that processing LEMI can be approached with a channel-map But where to put the channel map? There is a fork in the road here. |
It probably would live in the processing config. |
I have successfully remapped channels names on synthetic data using a dictionary and produced TFs from LEMI-like labelling on synthetic data. Some wrangling was needed to make the TF class in mt_metadata write out and to avoid
Will open a ticket on mt_metadata for this. |
ToDo:
|
Tests passing, only needed left is
|
Test is still failing on the beatles however. |
We are supporting most common combinations at this point such as |
-Added ChannelNomenclature and channel_nomenclature to config -weave ChannelNomenclature class into synthetic tests -added methods for setting default input/output/reference channels to processing config (may need mod for 4 channel stations) -changed channel_nomenclature from kwarg to ard in process_mth5 -modified TTFZ to use ChannelNomenclature class -removed dependencies on aurora.channel_nomenclature [Issue(s): #74]
In general it would be very nice to allow for generic channel labels.
"hx", "hy", "ex", "ey" are good channel labels, but it would be nice if we had a place where these default channel labels were stored, and a user could change these.
This relates to mth5 Issue38 https://github.com/kujaku11/mth5/issues/38 and mth5 Issue54
but more than just "h1", "h2", "h3", "e1", "e2", we should be able to support
"label1", "label2", "labelN"
This implies an underlying channel naming schema, that defaults to "hx", "hy", "hz", "ex", "ey" but could support "foo", "bar", "moonunit", "dweezil", etc.
If we want to do Egbert's MMT method, or other methods we can for example concatenate channel label and station name.
Note:
This is particularly important if we want to work in a transformed domain. For example PCA, ICA representations of the data will not correspond to the hexy convention.
The text was updated successfully, but these errors were encountered: