Merged Runs in Frequency Domain #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 69.50% 70.42% +0.92%
==========================================
Files 97 98 +1
Lines 5289 5535 +246
==========================================
+ Hits 3676 3898 +222
- Misses 1613 1637 +24
Continue to review full report at Codecov.
|
While working on issue#80, and PR184, have noticed that processing config defaults to estimator.engine = "RME_RR". This is fine, but I find I need to specify to use "RME" explicitly when there is only one station. So a couple fixes were added: 1. Processing class now has a validate() method. If there is no RR station, _and_ the estimator.engine is "RME_RR", it gets reset to "RME". Also added the ability to pass a kwarg to ConfigCreator instance called estimator. The kwarg is a dict and if "engine" is a key, it will overwrite the estimator with the corresponding value. The parkfield SS run test was updated to use the config_creator method. cas04 test is usign validate() [Issue(s): #80]
Tested clock zero works when it comes from data, but only on a single run. [Issue(s): #42]
-Added windowing_scheme as a property of decimation_level metadata object, and r eplaced initializations of WindowingScheme() in time_series_helpers, with this p roperty -cleaned up an errant print statement and tidied some docstrings [Issue(s): #42]
clock zero
Fixed a few docstrings, but main change was to review the math in squared coherence calculation. It turns out this is not as inefficient as I had thought, but it can be done a little cleaner. Removed an unneeded conjugation. [Issue(s): #78]
Fix issue 78
Allow request list to have mulitple stations and modify channel_summary_to_make_mth5 to groupby station,run rather than just run. Add tests of make multistation mth5 to cas04 tests. [Issue(s): #80]
Add a method to KernelDataset to extract run info, looping over runs. Also, noticed that some synthetic tests were commented out, fixed this. Also, tidied some code in process_mth5. [Issue(s): #181]
Multiple runs now entered into TF XML
Replaced dict with classes. Now have a SyntheticRun and a SyntheticStation. This will be used to create an example synthetic case with many runs [Issue(s): #80]
Change from timedelta.seconds to timedelta.total_seconds() Remove run_id from sort_by, it should be only station, starttime [Issue(s): #80]
|
The attached figures indicate that an integrated test using the RR mulitrun clipping to process cas04 with aurora is giving results that are consistent with EMTF in both amplitude and phase outside of the very noisy band of periods shorter than ~30s, which should be processed with coherence sorting. The good agreement at long period suggests that the management of time intervals is being handled correctly. The casor test will be revisited in issue #31 but these results are enough to justify merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to issues #80, #118 , #132.
Using CAS04 as a test to demonstrate can combine data from multiple runs
Tasks
This would not be too hard to to, but it is unclear if that this would improve readability. Better probably to deal first with issue Deprecate TransferFunctionHeader Class #109, and consider replacing the TF container class with that in mt_metadata.
Reported as issue Review Role of local_run_obj in export_tf #181
This is because runs c and d are missing filters for electric channels. In particular, run c has no filters for ey, and run d has no filters for ex, or ey. Added a note about this on issue CAS04 Dataset reconciliation #31. Ultimately, this was a consequence of a bug in make_mth5. This is addressed in issue Earthscope Dataset PAL59 #105 https://github.com/kujaku11/mth5/issues/105 in mth5.
This task not completed, but issue How to set start/end time for run #188 was created, and as a substitute test, CAS04 was processed with RR