Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #200: mth5 file_version=0.2.0 #201

Merged
merged 9 commits into from
Jul 30, 2022
Merged

Fix issue #200: mth5 file_version=0.2.0 #201

merged 9 commits into from
Jul 30, 2022

Conversation

kkappler
Copy link
Collaborator

-Reduce tests to only 3.8
-Add line counting function maybe needed for LEMI handler
-Updating operate_aurora to work with mth5 0.2.0 (incomplete)
-Edit comment on cas04/01 to indicate build of 0.2.0 working
-Add reprocess boolean arg to cas04/02 so can make plots without processing

[Issue(s): #200]

-Reduce tests to only 3.8
-Add line counting function maybe needed for LEMI handler
-Updating operate_aurora to work with mth5 0.2.0 (incomplete)
-Edit comment on cas04/01 to indicate build of 0.2.0 working
-Add reprocess boolean arg to cas04/02 so can make plots without processing

[Issue(s): #200]
also tidy doc in count_lines for code_cov

[Issue(s): #200]
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #201 (423a09e) into main (4612728) will increase coverage by 0.25%.
The diff coverage is 87.27%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   70.96%   71.21%   +0.25%     
==========================================
  Files          98       99       +1     
  Lines        5527     5597      +70     
==========================================
+ Hits         3922     3986      +64     
- Misses       1605     1611       +6     
Impacted Files Coverage Δ
tests/time_series/test_apodization_window.py 100.00% <ø> (ø)
tests/time_series/test_windowing_scheme.py 77.00% <ø> (ø)
aurora/transfer_function/kernel_dataset.py 55.47% <42.85%> (-0.17%) ⬇️
aurora/test_utils/synthetic/make_mth5_from_asc.py 82.52% <68.00%> (-1.18%) ⬇️
aurora/pipelines/process_mth5.py 95.83% <85.71%> (-0.60%) ⬇️
tests/test_general_helper_functions.py 94.73% <94.73%> (ø)
aurora/general_helper_functions.py 61.11% <100.00%> (+5.79%) ⬆️
aurora/pipelines/run_summary.py 88.57% <100.00%> (+2.40%) ⬆️
aurora/pipelines/time_series_helpers.py 90.26% <100.00%> (ø)
aurora/test_utils/synthetic/processing_helpers.py 75.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4612728...423a09e. Read the comment docs.

@kkappler kkappler changed the title Prep for issue #200 Fix issue #200: mth5 file_version=0.2.0 Jul 30, 2022
-Add logic to wrangle survey dict in case 0.2.0 vs 0.1.0 for creation of mt_metadata.trasfer_function.TF object in process_mth5
-modified synthetic data tests to be able to return mt_metadata.trasfer_function.TF instead of just the (to be deprecated) TransferFunctionCollection

[Issue(s): #200]
- Changed call to read_back_data to pass survey kwarg
- tested build and readback of CAS04 with mth5 file_version="0.2.0"
- added some extra lines to synthetic test to make codecov happier
- added test for general_helper_functions
- moved some tests into tests/time_series/

[Issue(s): #200]
@kkappler kkappler merged commit 76bb5be into main Jul 30, 2022
@kkappler kkappler deleted the fix_issue_200 branch August 28, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant