Add set_frequency_bands method to processing class #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carve a place for assignment of frequency bands via a list of band_edges. [Issue(s): #150]
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 77.50% 78.96% +1.45%
==========================================
Files 99 101 +2
Lines 5104 5306 +202
==========================================
+ Hits 3956 4190 +234
+ Misses 1148 1116 -32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fix issue 90 and issue 3134 with obspy seems to be fixed as well
Cleanup, towards issue#150. Also reduced to only one test (py3.8) [Issue(s): #150]
See Issue #218. Replace reference to bs_256 with bs_256_26 which has 3 fewer bands bs_256.cfg has 29 bands and has been giving unstable results on the test dataset at the lowest frequencies. To avoid this issue, I created a truncated file, bs_256_26.cfg, truncated to omit the 3 longest period bands (for which the matlab codes never showed results anyhow). The _26 file should be used for the matlab comparison test. [Issue(s): #218]
The files in config/emtf_band_setup/ were: bs_256_26.cfg bs_256.cfg bs_test.cfg And are from the EMTF FORTRAN code repository. bs_test.cfg is the boilerplate band_setup file, and normally goes with 128 point windows. bs_256.cfg has 29 bands and has been giving unstable results on the test dataset at the lowest frequencies. To avoid this issue, I created a truncated file, bs_256_26.cfg, truncated to omit the 3 longest period bands (for which the matlab codes never showed results anyhow). The _26 file should be used for the matlab comparison test. Renaming bs_256.cfg to bs_256_29.cfg, and make the test that compares output with the matlab codes use bs_256_26.cfg. [Issue(s): #218]
-Fix emtf_band_setup_files to import from their own __init__.py -Add _band_specification_style attr to ConfigCreator -add fftfreqs method to decimation_level -add method (assign_bands) to processing.py to allow (prototype) band specifcati ons -correct some definitions in band.json [Issue(s): #150]
Added a simple test that creates bands from manually accessing the band edges that are assocaited with the emtf band default file. [Issue(s): #150]
Now, even if band definition is from an emtf band setup file, band edges are defined and used. -Deprecated read_emtf_bands method in processing.py -added compute_band_edges method to EMTF band setup file -deprecated from_emtf_band_setup & from_emtf_band_df in frequency_band.py -also, cleaned up calls to fftfreqs, replacing with get_fft_harmonics where appropriate [Issue(s): #150]
-modified frequency_bands_obj() method of decimation_level.py to remove duplication of band_edges assignment -tried to remove all calls to deprecated from_emtf_band_df() method [Issue(s): #150]
-Add some properties to decimation_level and processing classes to make access of frequency_bands info easy from Processing objects -Use this change to update test_define_frequency_bands.py to access bands programatically [Issue(s): #150]
Added a band_specification_style to the processing config at the top level. The band_setup_file path is also written to the config is relevant [Issue(s): #150]
Streamlined some methods in frequency_bands marked as deprecated Tracked down last usage to a test for the matlab_z_file_reader Tuned up the test for the matlab_z_file_reader so that it has an assert statement [Issue(s): #150]
Also: -add a few docstrings from last commit -restore all three versions tests in prep for merge into main [Issue(s): #150]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carve a place for assignment of frequency bands via
a list of band_edges.
[Issue(s): #150]