Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #291

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Small fixes #291

merged 4 commits into from
Sep 15, 2023

Conversation

kujaku11
Copy link
Collaborator

Made a few fixes to help the processing run to completion.

  1. removing nan from window and setting nan values to mean of nanmean()
  2. Try/except statement when validating decimation levels
  3. Add logic if length of processing row is not 1

Take them as you like.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #291 (1f9af7c) into fourier_coefficients (d8b0c62) will decrease coverage by 0.08%.
The diff coverage is 65.11%.

@@                   Coverage Diff                    @@
##           fourier_coefficients     #291      +/-   ##
========================================================
- Coverage                 76.71%   76.64%   -0.08%     
========================================================
  Files                        86       86              
  Lines                      5463     5476      +13     
========================================================
+ Hits                       4191     4197       +6     
- Misses                     1272     1279       +7     
Files Changed Coverage Δ
aurora/pipelines/time_series_helpers.py 73.79% <58.82%> (-0.66%) ⬇️
aurora/pipelines/transfer_function_kernel.py 88.83% <69.23%> (-1.72%) ⬇️

Copy link
Collaborator

@kkappler kkappler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, these are helpful

@kkappler kkappler merged commit 7d999ea into fourier_coefficients Sep 15, 2023
8 of 10 checks passed
@kkappler kkappler deleted the remove_nan_in_run branch September 15, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants