Patches #330
Merged
Patches #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added reference to MTH5 paper - Capitalized `Python` - Added some to acknowledgements a statement needed by USGS
- use increment() and reset() functions instead
- move some previously hard coded values (r0,u0, tolerance) to be args. This will eventually get populated from the config - relates to #107
- merged regression params into mt_metadata patches branch - modifies trnasfer_function_helpers to set regression params from the config
- rename check_number_of_observations_xy_consistent to be an underscore function - make X, Y explicit arguments to RegressionEstimator, not kwargs - add typehinting for their current xr.Dataset dtypes - factor the assignement to numpy arrays into its own method _set_up_regression_variables
- move _check_number_of_observations_xy_consistent under _set_up_regression_variables() - remove unneeded extra call to that in TRME_RR
- can't see any reason to allow it, and it adds a bunch of checks later in the code
- add support for dataarray in regression - add a test to confirm dataarray OK
- add a test
- if we pass a dataarray made from .sel() of a single channel the underlying numpy is 1D. Force this to be 2D to make things smooth
- add attrs _input_channel_names, _output_channel_names to base regression - allow these to be passed if desired, otherwise deduce from xarray, or assign to numpy array - update m_estimator to use these attrs instead of assuming self._X, self._Y are xr.datasets
- also somt typehints/doc
- see #203. It will be easier to initialize an mt_metadata TF to replace this class rather than create a new version of TF
- sometimes when running this locally, you have a v0.2.0 mth5 file. - on github its v0.1.0. - added handling for local tests
- move helper function for mth5 data path into the only moudle that uses it (synthetic/paths.py) - reorganize tests
- comment out work in progress
- some zfiles and plots were landing in different folders - now everything should land in data/parkfield
- prepping to make WindowedTimeSeries have an FFT method
- add apply_fft method to WindowedTimeSeries - move fft_xr_ds into windowed_time_series from WindowingScheme - simplify windowing scheme, - remove duplicate logic for dataarrays and datasets - comment out apply_spectral_density_calibration (no longer used) - make process_mth5 (time_series_helpers) call new WindowedTimeSeries method
updating to main branches for testing
changed mth5 main to master
- have just merged move_to_mth5, sans ipynb - these will manual merge soon
- uncomment jupyter tests
|
Before merging in patches, we merged
Then manually fixed notebooks and committed on When the smoke cleared, there were a few files that didn't seem to have merged as desired -- it is not clear why, at least a few of these were worked on quite recently. The files were: test_process_parkfield_run.py Minor changes were applied to these, taking the latest, correct code from both branches. |
- otherwise the output makes the user think there is a warning. Also, switch to patches on mth5 to test hotfix there
- also add draft CITATION.cff (pending hash)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.