Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot_3d_slicer bug #159

Merged
merged 9 commits into from
May 17, 2019
Merged

Fix plot_3d_slicer bug #159

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e92b409
Fix plot_3d_slicer bug. Return figure
dccowan May 14, 2019
32ae616
Remove showIt. Remove redundant file
dccowan May 14, 2019
fed92ec
Remove plt.show()
dccowan May 14, 2019
50e1ce7
Merge branch 'master' into bug_fix_plot_3d_slicer
lheagy May 15, 2019
8ff4af5
Merge branch 'master' into bug_fix_plot_3d_slicer
thast May 15, 2019
1b2cafb
Remove according to review comments
dccowan May 16, 2019
94d4e67
Ignore link
dccowan May 16, 2019
f93aeba
Merge branch 'master' into bug_fix_plot_3d_slicer
lheagy May 16, 2019
4694ff9
Update docs/conf.py
lheagy May 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions discretize/View.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,8 +777,7 @@ def plot_3d_slicer(self, v, xslice=None, yslice=None, zslice=None,
# Connect figure to scrolling
fig.canvas.mpl_connect('scroll_event', tracker.onscroll)

# Show figure
plt.show()
return fig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @prisae: just a small functionality update here I wanted to bring you in on. It seems like there are some use-cases where having access to the figure handle outside would be handy if it is generated inside this function. Does this work for you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no problem, I don't have any hard feelings with regards to how this is handled. I did not overly adjust the plot_3d_slicer from my usage/style to SimPEG-style. I think the idea was we just bring it in, and then adjust it where necessary, so perfectly fine by me.



class CylView(object):
Expand Down