Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib warnings: norm + vmin, vmax #226

Closed
wants to merge 1 commit into from
Closed

Conversation

lheagy
Copy link
Member

@lheagy lheagy commented Sep 22, 2020

update the logic in plotting so that we don't pass both a norm and vmin, vmax to resolve the Matplotlib warning:

MatplotlibDeprecationWarning: Passing parameters norm and vmin/vmax simultaneously is deprecated since 3.3 and will become an error two minor releases later. Please pass vmin/vmax directly to the norm when creating it.

@lheagy lheagy requested a review from jcapriot September 22, 2020 20:24
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #226 into master will decrease coverage by 0.05%.
The diff coverage is 64.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   82.59%   82.53%   -0.06%     
==========================================
  Files          24       24              
  Lines        5488     5504      +16     
==========================================
+ Hits         4533     4543      +10     
- Misses        955      961       +6     
Impacted Files Coverage Δ
discretize/View.py 70.84% <64.70%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60375c9...e953b98. Read the comment docs.

@prisae prisae mentioned this pull request Sep 25, 2020
@jcapriot jcapriot closed this Nov 17, 2020
@prisae
Copy link
Member

prisae commented Nov 18, 2020

Along the lines of what I mentioned in #227 - I think it is good to mention why something (issue/PR) was closed, e.g., fixed in #xyz, it was decided it will not be fixed, this is outdated due to xyz, etc.

Users often stumble to (open or closed) GitHub issues and PR's, so it is good to guide them to the solution.

This issue was fixed in #227.

@jcapriot jcapriot deleted the pcolormesh-warnings branch January 27, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants