Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyl mesh generalization #321

Merged
merged 25 commits into from
May 30, 2023
Merged

Conversation

jcapriot
Copy link
Member

@jcapriot jcapriot commented May 9, 2023

Generalizes the Cylindrical mesh to not be hard-coded starting at r=0 or having a full azimuthal discretization.

image
image
image

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #321 (7704fc4) into main (0f9fe1f) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   85.41%   85.69%   +0.28%     
==========================================
  Files          38       38              
  Lines       11420    11580     +160     
==========================================
+ Hits         9754     9924     +170     
+ Misses       1666     1656      -10     
Impacted Files Coverage Δ
discretize/base/base_tensor_mesh.py 88.45% <100.00%> (ø)
discretize/cylindrical_mesh.py 96.54% <100.00%> (+2.32%) ⬆️
discretize/mixins/mpl_mod.py 72.59% <100.00%> (+0.07%) ⬆️
discretize/mixins/vtk_mod.py 88.76% <100.00%> (+0.91%) ⬆️
discretize/tests.py 81.02% <100.00%> (+0.28%) ⬆️

... and 3 files with indirect coverage changes

@jcapriot jcapriot marked this pull request as ready for review May 30, 2023 23:45
@jcapriot jcapriot merged commit bfb9237 into simpeg:main May 30, 2023
@jcapriot jcapriot deleted the cyl_mesh_improvements branch May 30, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant