Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use any Python 3 in pre-commit #328

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Jun 16, 2023

Unpin Python 3.10 in pre-commit configuration and use any available Python 3 interpreter. This fixes issues when the Python version in the environment is not 3.10.

Unpin Python 3.10 in pre-commit configuration and use any available
Python 3 version. This fixes issues when the Python version in the
environment is not 3.10.
@santisoler
Copy link
Member Author

@jcapriot I run into some errors today because the environment I had for discretize wasn't running python 3.10, and pre-commit wasn't throwing some errors when trying to create the virtual environments. Since we are pinning the black and flake8 versions, the python version shouldn't be so important.

If you think otherwise, then I suggest pinning a python version in the environment_test.yml.

@santisoler santisoler changed the title Use any python3 in pre-commit Use any Python 3 in pre-commit Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #328 (17c23f0) into main (e14e13e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   85.16%   85.16%           
=======================================
  Files          38       38           
  Lines       11538    11538           
=======================================
  Hits         9826     9826           
  Misses       1712     1712           

@jcapriot
Copy link
Member

Yeah, this should be fine. I know I was having issues getting pre-commit to run properly on windows on anything less than 3.10

@jcapriot jcapriot merged commit 0c036c7 into simpeg:main Jun 23, 2023
@santisoler santisoler deleted the pre-commit-py3 branch June 23, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants