Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TreeCell.bounds and TreeMesh.cell_bounds methods #367

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

santisoler
Copy link
Member

Work in progress

Add a new TreeCell.bounds method that return the bounds of a cell in
a TreeMesh.

  • Start drafting cell_bounds method

Add a new `TreeCell.bounds` method that return the bounds of a cell in
a `TreeMesh`.
Start drafting a `cell_bounds` method for the `TreeMesh`.
@jcapriot
Copy link
Member

jcapriot commented Sep 2, 2024

Let's add the relevant information to the underlying c++ Cell class, so you can access it easier in the TreeMesh as well.

@santisoler
Copy link
Member Author

Let's add the relevant information to the underlying c++ Cell class, so you can access it easier in the TreeMesh as well.

I agree. I would appreciate if you could help a little bit with that, or just point me in the right direction on how is the best way to do so.

@jcapriot
Copy link
Member

jcapriot commented Sep 3, 2024

Branching from #356 would be easiest, as I had put a little bit of the functionality in there already. It lets you just grab the minimum and maximum node for the c_cell pretty easily.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (87b9300) to head (fa45e02).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   86.12%   86.15%   +0.03%     
==========================================
  Files          90       90              
  Lines       18494    18538      +44     
  Branches     2089     2093       +4     
==========================================
+ Hits        15928    15972      +44     
  Misses       1882     1882              
  Partials      684      684              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot
Copy link
Member

@santisoler this should be good now

@jcapriot jcapriot marked this pull request as ready for review October 12, 2024 21:42
Copy link
Member Author

@santisoler santisoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just pushed one extra test to make sure that the bounds are returned in the right order. Feel free to merge.

Copy link
Member

@jcapriot jcapriot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let’s merge

@jcapriot jcapriot merged commit e6b3a87 into main Oct 16, 2024
25 checks passed
@jcapriot jcapriot deleted the tree-mesh-cell-bounds branch October 16, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants