-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TreeCell.bounds
and TreeMesh.cell_bounds
methods
#367
Conversation
Add a new `TreeCell.bounds` method that return the bounds of a cell in a `TreeMesh`.
Start drafting a `cell_bounds` method for the `TreeMesh`.
Let's add the relevant information to the underlying c++ Cell class, so you can access it easier in the |
I agree. I would appreciate if you could help a little bit with that, or just point me in the right direction on how is the best way to do so. |
Branching from #356 would be easiest, as I had put a little bit of the functionality in there already. It lets you just grab the minimum and maximum node for the c_cell pretty easily. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 86.12% 86.15% +0.03%
==========================================
Files 90 90
Lines 18494 18538 +44
Branches 2089 2093 +4
==========================================
+ Hits 15928 15972 +44
Misses 1882 1882
Partials 684 684 ☔ View full report in Codecov by Sentry. |
@santisoler this should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just pushed one extra test to make sure that the bounds are returned in the right order. Feel free to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let’s merge
Work in progress
Add a new
TreeCell.bounds
method that return the bounds of a cell ina
TreeMesh
.cell_bounds
method