Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display dev doc banner #373

Merged
merged 1 commit into from
Sep 8, 2024
Merged

display dev doc banner #373

merged 1 commit into from
Sep 8, 2024

Conversation

jcapriot
Copy link
Member

@jcapriot jcapriot commented Sep 7, 2024

Apparently... (and this is not well documented), for the pydata-sphinx-theme to display the development banner either:

  • the string dev, rc, or pre must appear in the "version" for the matcher
  • or the version must compare greater than the preferred version.

So this just gives the main branch a dev version in the matcher, and also makes the json_url point to the version on main

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.25%. Comparing base (24ea070) to head (92619f3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files          89       89           
  Lines       18695    18695           
  Branches     2959     2959           
=======================================
  Hits        16125    16125           
  Misses       1884     1884           
  Partials      686      686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot jcapriot merged commit 98caca7 into simpeg:main Sep 8, 2024
25 checks passed
@jcapriot jcapriot deleted the dev_doc_banner branch September 8, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant