Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor base class #48

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Refactor base class #48

wants to merge 9 commits into from

Conversation

jcapriot
Copy link
Member

@jcapriot jcapriot commented Sep 28, 2024

This refactor is aimed at increasing consistency throughout the package, adding a few bits of missing information.

  • Gets rid of the ugly set_kwargs funciton.
  • Automatically do a check for symmetry and hermitian, if not given.
  • Exposes a solve() operation that broadcast's like np.linalg.solve.
  • Uses Scipy's triangular solver for Forward and Backward class (and makes them transposes of each other).
  • Check's wrapped function signatures for valid keyword arguments.
    • Emits warnings on unused keyword arguments.
  • add a solver.transpose() method, which is aliased as a property as solver.T.
  • Define's Base as an abstract class, where subclasses must implement a _solver_single and a _solve_multiple.
  • Mimic's scipy's more recent rtol and atol keywords for solution checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant