-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
679 Change of attributes for added individuals #698
Conversation
Merge sprint 4.
Authored-by: kysrpex <kysrpex@users.noreply.github.com> Authored-by: José Manuel Domínguez <jose.manuel.dominguez@iwm.fraunhofer.de> (cherry picked from commit 3251c71) * OSP-core incompatible with RDFLib 6.0.0 (#678) Authored-by: kysrpex <kysrpex@users.noreply.github.com> Authored-by: José Manuel Domínguez <jose.manuel.dominguez@iwm.fraunhofer.de> (cherry picked from commit fa6ebcd) * Bump OSP-core version to 3.5.5 in hotfix branch for bugfix release. Authored-by: kysrpex <kysrpex@users.noreply.github.com> Authored-by: José Manuel Domínguez <jose.manuel.dominguez@iwm.fraunhofer.de>
@pablo-de-andres @yoavnash You are seeing now what will be merged to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move detailed warning to web page and refer to it by link.
I started to do this and it fits in the CUDS API tutorial. However, the problem is that our readthedocs deployment does seem to render all docs versions. Thus, if somebody is using an old version of OSP-core, they will be linked to the latest version of the docs, which may show a different text. I think fixing this aspect of readthedocs maybe is too much for an issue that is critical. We can do it later when this deployment thing is sorted out. |
Authored-by: kysrpex <kysrpex@users.noreply.github.com> Authored-by: José Manuel Domínguez <jose.manuel.dominguez@iwm.fraunhofer.de> (merged from 2d71d21)
I already merged this to master and released the hotfix. For |
This reverts commit 4eddd45.
…ed_individuals' into 679-Change_of_attributes_for_added_individuals
See the linked issue for more details on the problem. The new behaviour will be the following for the next stable release that will be released from this hotfix branch.
rdflib 5.0.0
A slightly different version of the warning will be merged to dev, since on dev you can upgrade to rdflib 6.0.0 given that you have the proper Python version installed.
rdflib 5.0.0
On dev the dev branch, and with
rdflib >= 6.0.0
installed, the user will see no warning, and in-place modification will work.Upsides:
Downsides:
It's thus tricky to decide whether to define this as an incompatible API change (major version increase) or an error correction (patch version increase), as the in-place modification was a grey area. Maybe let's go for the error correction, given that the warning is there and makes it easy for the user to fix behaviour reliant on in-place modifications.
Edit: actually, the changes introduced to
dev
should increase the minor version number, we are promoting in-place modification from a grey area to an authorized feature, in a backwards-compatible way.Closes #679. Merge first to master, merge also to dev (change the contents of
setup.py
to the appropriate ones after merging to master, restore thedev
warning after merging to master). Since this is a critical fix, the package version was bumped.