Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce specificity of Element check in findTargetElement. #76

Merged

Conversation

adriancooney
Copy link
Contributor

@adriancooney adriancooney commented Apr 10, 2018

Fixes #75.

I wasn't entirely sure where to put a test case for this so I said I'd wait for feedback from someone with some context. Has anyone any suggestions on where to put a test for this? Is there tests for findTargetElement I'm missing?

@Turbo87
Copy link
Collaborator

Turbo87 commented Apr 10, 2018

Is there tests for findTargetElement I'm missing?

no, there are no dedicated tests for this method, because it's not public API. you could add a test case for SVGs to the tests of assert.dom().exists()

@Turbo87 Turbo87 added the bug label Apr 10, 2018
@adriancooney
Copy link
Contributor Author

@Turbo87 funnily enough, that's exactly where I wanted to put the test in the first place myself and I found that exists doesn't use the findTargetElement method. I could throw one into hasAttribute tests?

@Turbo87
Copy link
Collaborator

Turbo87 commented Apr 10, 2018

and I found that exists doesn't use the findTargetElement method.

whoops, you're right :D

I could throw one into hasAttribute tests?

yeah, seems good to me :)

@adriancooney
Copy link
Contributor Author

@Turbo87 test added!

Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@Turbo87 Turbo87 merged commit 5b39360 into mainmatter:master Apr 10, 2018
@adriancooney adriancooney deleted the adrian.cooney/accept-svg-element branch April 10, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants