Add compatibility with ember-qunit@5

[rwjblue]

In order to add support for ember-qunit@5 the primary Ember project usage pattern changes a bit:

// tests/test-helper.js
import * as QUnit from 'qunit';
import { setup } from 'qunit-dom';
//...snip...
setup(QUnit.assert);

No change is required for ember-qunit < 5 (this should not be a breaking change).

Closes #812

[scalvert]

Looks good so far. Thanks for implementing explicit calls vs. side-effect imports!

[scalvert]

What's the status of this PR, @rwjblue? Can we publish for review, or are you still poking at it?

Also, publishing ember-qunit, @ember/test-helpers, and others will require a bit of coordination. Do we have a parent issue that determines the correct order of rollout for all these releases, other than Rob's head? :)

[rwjblue]

What's the status of this PR, @rwjblue? Can we publish for review, or are you still poking at it?

I still have a few TODO's that need to be completed.

Also, publishing ember-qunit, @ember/test-helpers, and others will require a bit of coordination. Do we have a parent issue that determines the correct order of rollout for all these releases, other than Rob's head? :)

Good idea! Created ember-cli/ember-cli#9335 with the TODOs.

[scalvert]

Just did a rebase to fix merge conflicts.

[rwjblue]

https://github.com/rwjblue/--ember-qunit-5-sample-app is a demo app that uses the "whole new setup" and is passing.

[scalvert]

In terms of the API we expose to users, I'd prefer that we use the pattern that requires the hosting project to pass in QUnit to extend.

import { setup } from "qunit-dom"; 

// ...

setup(QUnit);

This will not require any special configuration from qunit-dom itself, in addition to not making any assumptions about the consumer's configuration of their project.

Thoughts?

[rwjblue]

In terms of the API we expose to users, I'd prefer that we use the pattern that requires the hosting project to pass in QUnit to extend.

Ya, agreed. That's what the current implementation does (though I need to push a commit to the demo repo above with that change in it).

[scalvert]

In the PR description, these two are the same thing, no?

Document a new API (still somewhat TBD, but probably import "qunit-dom" or import { setup } from "qunit-dom"; setup(QUnit);
Decide if setup should accept QUnit argument or directly import it?

[scalvert]

@rwjblue I updated the description to better reflect the actual final work for this PR.

[scalvert]

@Turbo87 I think we've managed to get this into a decent state. The only thing we haven't done here is add automated tests that test the Ember variant with ember-qunit > 5, but @rwjblue has a repo that he's been using to manually test. How do we think we should handle this?

[Turbo87]

LGTM after these minor comments are resolved. nice work! 👍