You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been checking compatibility with Embroider and various Addons in the community and I came across that this addon is incompatible.
Specifically I was trying to add ember-try Embroider configuration to Ember Power Calendar, which uses this addon, but the tests fail on its custom assertion usage. The problem is that the custom assertions that the Power Calendar tests add aren't added to the global QUnit object.
Uncaught TypeError: assert.isDay is not a function
Doing a bit of digging I came across this issue (and PR), on the qunit-dom repo which similarly tries to add custom assertions to the global QUnit object. It appears this is no longer possible under ember-qunit v5 (migration guide) which is required to support Embroider.
tooling can no longer depend on the QUnit global to be defined
From the looks of it there appear to be a few changes that need to be made for it to work to support ember-qunit v5 (and therefore Embroider).
For example in qunit-dom, users now bootstrap the assertions in test-helper.js and pass in QUnit.assert.
Trying to run the tests I put together a branch which has Embroider + ember-try setup but I think to start, the repo will need be updated to use a newer ember-cli for it to work.
The text was updated successfully, but these errors were encountered:
I've been checking compatibility with Embroider and various Addons in the community and I came across that this addon is incompatible.
Specifically I was trying to add ember-try
Embroider
configuration to Ember Power Calendar, which uses this addon, but the tests fail on its custom assertion usage. The problem is that the custom assertions that the Power Calendar tests add aren't added to the globalQUnit
object.Doing a bit of digging I came across this issue (and PR), on the
qunit-dom
repo which similarly tries to add custom assertions to the globalQUnit
object. It appears this is no longer possible under ember-qunit v5 (migration guide) which is required to support Embroider.From the looks of it there appear to be a few changes that need to be made for it to work to support ember-qunit v5 (and therefore Embroider).
For example in qunit-dom, users now bootstrap the assertions in
test-helper.js
and pass inQUnit.assert
.Trying to run the tests I put together a branch which has Embroider + ember-try setup but I think to start, the repo will need be updated to use a newer ember-cli for it to work.
The text was updated successfully, but these errors were encountered: